search

bartsqueezy / ember-handlebars-brunch

This Brunch plugin adds support for pre-compiling Ember Handlebars templates prior to runtime
MIT License
9 stars 32 forks source link

Updated compiler for rc 6 and handlebars to 1.0 - 4 #8

Closed ryanmarc closed 11 years ago

ryanmarc commented 11 years ago

steedlefronts...

jerodsanto commented 11 years ago

@ryanmarc this looks almost all good, except it appears that you appended to vendor/handlebars.js instead of replacing the old one with the new one. This broke my build.

Was that an accident or did you have a reason to do it that way?

(I forked and made a similar commit which worked for me here)

ryanmarc commented 11 years ago

No, that would be a mistake. I probably just messed it up when I was pasting the new content in. I'll update this commit in the morning.

ryanmarc commented 11 years ago

This has been fixed.

bartsqueezy commented 11 years ago

This plugin has now been updated to the latest version of ember.js - v1.0.0. I've tagged every commit that points to a different version of ember.js. This will follow standard practice by allowing the developer to choose which version of this plugin they want to include in their project. Please update your package.json to reference the version of ember you want this plugin to pre-compile templates for (e.g. 1.0.0-rc.7, 1.0.0-rc.8, 1.0.0, etc).

Sorry for the wait!