parallel_nmt - Githubissues

bartvm / nmt

Neural machine translation

MIT License

2 stars 2 forks source link

parallel_nmt #9

Closed anirudh9119 closed 8 years ago

bartvm commented 8 years ago

Sorry for the late reply. The code overall looks good, but I'm not very keen on copy-pasting the Platoon code. It will be a pain to keep up to date. @rizar recently turned it into a package, so that should make it easier to just use it as a separate Python package.

anirudh9119 commented 8 years ago

I have also turned it into a python package, but that was still to be documented. I will complete that sometime today.

nouiz commented 8 years ago

Platoon was updated with small interfaces changes. I just wanted to let you know.

bartvm commented 8 years ago

@anirudh9119 Can you merge the multi-GPU stuff with @JinseokNam's other work then, so that we can merge both into master?

Use Platoon as a package (i.e. don't copy-past)
Make multi-GPU stuff optional
Use the latest launcher in Platoon
Set some sensible defaults for e.g. 2 or 4 GPUs, that work based on your experiments