search

baruchiro / use-route-as-state

Use React Router route and query string as component state
https://baruchiro.github.io/use-route-as-state/
MIT License
42 stars 7 forks source link

react-router-6 migration #177

Open s-roueche opened 2 years ago

s-roueche commented 2 years ago

This PR is not finish yet.

4 tests failed.

itayganor commented 2 years ago

Are all the syntax changes necessary for this PR?

s-roueche commented 2 years ago

Are all the syntax changes necessary for this PR?

It's not necessary 👍

baruchiro commented 2 years ago

Are all the syntax changes necessary for this PR?

It's not necessary 👍

If you can, I will suggest removing formatting changes to easily focus on what was really changed.

Consider adding ESLint/Prettier in another PR.

baruchiro commented 2 years ago

Regarding the tests, I also don't know why they are failing.

Is the example website working well? Did you try to use the V6 version in your code?

Maybe we need to re-write the tests, or skip them for now. What do you think?