baryluk
commented
10 months ago Thanks for fixing the issue. It is pretty obvious now what was going on with the FIFO blocking the logger. The separation into functions and cleanup of some old code, also make sense.
I do have one request tho.
Instead of config parsers and config file, could you just make it use argparse and command line flags, at the start of the def main():
I really do not like having config files, or extra dependencies (no matter how small).
Something like this:
def main():
...
import argparse
parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter)
parser.add_argument("--crc", type=bool, help="Enable CRC checks", default=False)
parser.add_argument("--dev", type=str, help="....", default="")
args = parser.parse_args()
...
crc_checker = None # alternatively lambda x: True
if args.crc:
import crc
crc_checker = lambda_or_something
# use args.dev to find specific device (i.e. by USB path/bus/device id)
You can make --crc default to False, or auto-detect by trying to import (I think we might be already doing this).
For booleans on command line I usually use a helper like this:
def str2bool(v: Union[str, bool], default_on_error: bool) -> bool:
if isinstance(v, bool):
return v
vl = v.lower()
if vl in ("yes", "true", "t", "1"):
return True
if vl in ("no", "false", "f", "0"):
return False
# raise ValueError("str2bool argument type must be true or false, found {v}")
return default_on_errorThen in argparse, I use it like this:
parser.add_argument("--crc", type=str2bool, help="Enable CRC checks", default=True)Then can do --crc=false, --crc=0, etc
luismeruje
Separated code into functions. Added configuration file to enable/disable crc check, which does not work for all devices (left it disabled by default). The program now exhausts all reads before exiting the program when a Keyboard Interrupt occurs. This changes help with issues #12 and #7.