search

baryluk / fnirsi-usb-power-data-logger

Driver / Data logger for FNIRSI FNB48, FNIRSI C1 and FNIRSI FNB58 USB Power meter
MIT License
152 stars 17 forks source link

Added Windows support #18

Open sheikhmishar opened 11 months ago

sheikhmishar commented 11 months ago

I have tried using this awesome logging utility on linux. It works flawlessly. However, sometimes I have to use Windows PCs and that's all I have in those moments. Added some exception handling to handle some unimplemented features in Windows kernel. Also, added an easy instruction for Windows in README.md

baryluk commented 10 months ago

Hi @sheikhmishar

Thanks for the interest, and making it work on Windows. Cool you find it useful.

I would need to think if I want this code change in this repo. I despise Windows, and even a hint of code complication to support it would be reject. But your patch looks harmless enough, and does not have any OS detection, so should be easy to maintain. So maybe I could accept it.

I will get back to you after some more thinking.

sheikhmishar commented 10 months ago

You're most welcome. Previously I used OS detection. But, later realized that exclusive usb device access is kernel dependant. So, whether you're on linux or any other platform, the exception can occur anywhere. I've seen such crucial feature not implemented in linux based OSes on single board computers like bananaPi. So, whether you want Windows support or not, the exception handling should be added anyway

sheikhmishar commented 10 months ago

Also, if we as developers really want to support the community, we cannot be so picky about things and despise an OS just because we personally don't like something about it. There are tons of great things in Windows and lots of which are nowadays integrated in linux based platforms. If Windows is a way to benefit people, who are we to do the gatekeeping???