Various optimizations - Githubissues

adferrand commented 5 years ago

So, this PR includes the following improvments:

integration tests are executed using the new certbot-ci project, that is a complete rewrite of these tests in Python
snap is compiled using Python 3
use more of the Travis paradigm in the pipeline
fix acme as a part in the snap, to compile against its latest version
pin certbot dependencies
basic tests for Apache

adferrand commented 5 years ago

Also, please consider my PR is a work in progress for now. I am rebuilding slowly each component, trying to understand the meaning on snap side, and the best compatibility on certbot side.

adferrand commented 4 years ago

@basak, this PR is ready!

basak commented 4 years ago

Thanks. This looks good!

Unfortunately I think it breaks the Apache plugin. Please could you take a look? When I try:

$ sudo certbot --test-cert --apache

I get:

Saving debug log to /var/log/letsencrypt/letsencrypt.log
The apache plugin is not working; there may be problems with your existing configuration.
The error was: NoInstallationError('Problem in Augeas installation',)

https://github.com/basak/certbot-snap-build/issues/8 is Apache tests not being in CI (since they aren't in upstream CI). Perhaps we should add our own minimal smoke test if upstream don't plan on adding this soon?

adferrand commented 4 years ago

@basak, the snap is working now for Apache !

basak commented 4 years ago

Thank you!

basak / certbot-snap-build

Various optimizations #10