search

basak / certbot-snap-build

0 stars 3 forks source link

Build fails when certbot depends on acme features not yet released into PyPI #12

Closed basak closed 4 years ago

basak commented 5 years ago

Details at: https://forum.snapcraft.io/t/building-a-snap-with-a-multi-python-project/12284

basak commented 5 years ago

This affects only edge since this situation will never arise on builds of released versions of certbot.

basak commented 4 years ago

Sergio suggested something like this as a workaround:

parts:
    p:
        source: certbot.git
        plugin: python
        python-packages:
        - http://dependency.git

We can give this a try when the situation next arises.

basak commented 4 years ago

This workaround seemed to work on Xenial, but after merging in Bionic it seems to have stopped working. So this bug is now not worked around at all, and CI is currently red.

bmw commented 4 years ago

I think this is fixed.

basak commented 4 years ago

@bmw

I'm not sure it is. See for example https://travis-ci.org/basak/certbot-snap-build/builds/651966533 - at a quick glance, that seems like the usual failure?

bmw commented 4 years ago

With https://github.com/basak/certbot-snap-build/pull/26, now my understanding is this is fixed.

basak commented 4 years ago

Agreed. Thanks!