search

basak / certbot-snap-build

0 stars 3 forks source link

Remove arch-specific paths #25

Closed popey closed 4 years ago

popey commented 4 years ago

The $SNAPCRAFT_ARCH_TRIPLET variable can be used at build time to ensure we don't have arch specific library paths used.

basak commented 4 years ago

Thanks. Looks good!

Unfortunately CI is broken at the moment for an unrelated reason. We can land this once that other issue is fixed and CI then passes on this branch. Presumably with the master branch builds broken there's no reason this needs to land sooner?

basak commented 4 years ago

Could you rebase this onto current master please? @adferrand has fixed the build, so I think this will pass CI then, and then we can merge. I assume rebasing is the right way to catch up with that fix, or is there some other way to cause Travis to test the result of merging this against master?

popey commented 4 years ago

I honestly don't know what to do. I tried, and failed at git. This two line simple fix has eaten an hour of my life. I'd say just delete it and do the change yourself as you see fit.