basarat / god-extra

Repository for issues and docs on God mode for VSCode
https://marketplace.visualstudio.com/items?itemName=basarat.god
5 stars 0 forks source link

Feature request: Support "jest" property in package.json #5

Closed Meligy closed 6 years ago

Meligy commented 6 years ago

Hello, Thanks for the super awesome free VSCode extension.

Would it be possible for the Jest support to use the "jest" top property in "package.json", as an alternative to "jest.config.js"?

Thanks again.

Cheers,

basarat commented 6 years ago

It is actually not that hard.

image

But decided not to do it because:

PS: Thanks for appreciating the extension :rose:

Meligy commented 6 years ago

Um. do you think the extension really needs to enforce its opinion on this one?

I mean: there are a couple of different topics here:

I can easily agree on the first point, that having a separate config is more superior. But if the team for one reason or another used package property, it's hard to convince them to switch to config when the only immediate difference is that the tool I personally use likes it.

It makes sense if it makes providing some of the features harder or the code too messy, but if not, would adding that barrier be more valuable than removing it?

Certainly your call, and your (awesome) extension. Just wanted to share a few thoughts on the topic.