basbruss / adaptive-cover

An Adaptive Cover component for HomeAsisstant to control covers based on the sun's position
MIT License
71 stars 10 forks source link

Changing Setting(s) Forces Adaptive To Run Even When Disabled #142

Closed Colorado4Wheeler closed 3 months ago

Colorado4Wheeler commented 4 months ago

What version of Adaptive Cover are you using?

1.1.3

What version of Home Assistant are you using?

2024.4.4

Checklist

Describe the issue

If you have disabled the toggle control on an Adaptive cover and change the settings for the cover, it will run. The expectation is that the settings save and apply but the cover still honors the toggle state.

Reproduction steps

  1. Disable an Adaptive Cover
  2. Change the settings on the cover (in my case it was the left angle via Fine Tune)
  3. Submit the change
  4. Adaptive runs ...

Diagnostics dump

No response

basbruss commented 4 months ago

Thanks! Never noticed it but was able to reproduce. Fixed with #143