basbruss / adaptive-cover

An Adaptive Cover component for HomeAsisstant to control covers based on the sun's position
MIT License
90 stars 11 forks source link

AdaptiveHorizontalCover not using `height_awning` #175

Closed mion00 closed 4 months ago

mion00 commented 4 months ago

What version of Adaptive Cover are you using?

1.2.0

What version of Home Assistant are you using?

2024.5

Checklist

Describe the issue

From the source code, it seems as if the config entry height_awning is not used in any way by the AdaptiveHorizontalCover. Maybe it was used in a previous version of the calculation.py?

Reproduction steps

Searched the source code for reference to the CONF_HEIGHT_AWNING constant.

Diagnostics dump

No response

basbruss commented 4 months ago

Thanks for mentioning this, I will take a closer look at in when I have more time. It could be that the value used in the calculation is not correct.