basbruss / adaptive-cover

An Adaptive Cover component for HomeAsisstant to control covers based on the sun's position
MIT License
90 stars 11 forks source link

At maximum position the motor is still activated #222

Closed Wizzard72 closed 2 months ago

Wizzard72 commented 3 months ago

What version of Adaptive Cover are you using?

1.3.1

What version of Home Assistant are you using?

2023.6.3

Checklist

Describe the issue

When the screen is at maximum position (100%), i hear the screen controller clicking, which means that the controller gets a command. This clicking interval is the same as the configured interval.

Does the code/integration check if the screen is in maximum position?

Reproduction steps

  1. Configure Adaptive Cover
  2. Wait until ir reached the maximum calculated position
  3. Listen if you hear the controller clicking ...

Diagnostics dump

I try to get one

Wizzard72 commented 3 months ago

Looks like version 1.3.2 solves this issue

Wizzard72 commented 3 months ago

I was wrong. When the screen is closed (0%), the screen switch is clicking every 2 minutes. The minimal posotion change is 10% and the minimal time change is 5 minutes.

basbruss commented 3 months ago

Thanks, I added a check to all service calls to see if the cover is already in the correct position.

Wizzard72 commented 2 months ago

Solved