basbruss / adaptive-cover

An Adaptive Cover component for HomeAsisstant to control covers based on the sun's position
MIT License
112 stars 12 forks source link

End of manual override controls cover even when outside of start/endtime range #286

Open mvdwetering opened 3 months ago

mvdwetering commented 3 months ago

What version of Adaptive Cover are you using?

1.4.3

What version of Home Assistant are you using?

2024.8.0

Checklist

Describe the issue

I noticed that the cover controlled by adaptive cover integration would move at unexpected times.

I only want the integration to do stuff between 8:30 and 23:00 so I set those as start/endtime in the automation settings. I have manual override set to 8 hours.

It seems that when the manual override period ends the cover goes to a position (probably default position) since the unexpected cover movement happened 8 hours and 2 minutes after I controlled the cover manually. I also tried disabling the manual override by pressing the Reset Manual override button with an automation and then the cover moved at the time the button was pressed.

I am expecting no actions from the integration since it is after endtime and before starttime

Reproduction steps

  1. set a start and endtime
  2. set a manual override duration say 1 hour
  3. do manual control 10 minutes before endtime and make sure it does not end up at its default position
  4. wait until manual override expires
  5. cover moves

Diagnostics dump

config_entry-adaptive_cover-743f1be574f1629abb765de084dc166c.json