basbruss / adaptive-cover

An Adaptive Cover component for HomeAsisstant to control covers based on the sun's position
MIT License
112 stars 12 forks source link

Manual override not triggered #301

Open cregeland opened 2 months ago

cregeland commented 2 months ago

What version of Adaptive Cover are you using?

1.4.3

What version of Home Assistant are you using?

2024.9.0

Checklist

Describe the issue

When a vertical screen is configured the manual override button is not triggered when controlling the cover manually (mushroom cover card).

Reproduction steps

  1. Configure vertical screen with correct azimuth, height etc
  2. Adaptive Cover integration moves the vertical screen to a position (i.e 50% closed)
  3. The user would like the cover full open for a while so the screen is controlled full open using the mushroom cover card
  4. The manual override button remains in the off position.
  5. I have tried leaving the manual override threshold off and also with different values. Same issue.
  6. The cover reports position "live" as it moves - 0-100% as well as status open, opening, closing and closed.

Diagnostics dump

"data": { "title": "Adaptive Cover Configuration", "type": "config_entry", "identifier": "01J71K2RVDRRVCNFVVVZ017AT1", "config_data": { "__type": "<class 'mappingproxy'>", "repr": "mappingproxy({'name': 'Familierom', 'sensor_type': 'cover_blind'})" }, "config_options": { "__type": "<class 'mappingproxy'>", "repr": "mappingproxy({'mode': 'basic', 'set_azimuth': 302.0, 'window_height': 2.8, 'distance_shaded_area': 0.5, 'default_percentage': 100.0, 'max_position': None, 'min_position': None, 'fov_left': 90.0, 'fov_right': 90.0, 'group': ['cover.screen_1_224_1_familierom_d3'], 'inverse_state': False, 'sunset_position': 0.0, 'sunset_offset': 0.0, 'sunrise_offset': 0.0, 'length_awning': None, 'angle': None, 'slat_distance': None, 'slat_depth': None, 'tilt_mode': None, 'temp_entity': None, 'presence_entity': None, 'weather_entity': None, 'temp_low': None, 'temp_high': None, 'outside_temp': None, 'climate_mode': False, 'weather_state': None, 'delta_position': 20.0, 'delta_time': 10.0, 'start_time': '00:00:00', 'start_entity': None, 'manual_override_duration': {'minutes': 15}, 'manual_override_reset': False, 'manual_threshold': None, 'manual_ignore_intermediate': False, 'blind_spot_right': None, 'blind_spot_left': None, 'blind_spot_elevation': None, 'blind_spot': False, 'min_elevation': None, 'max_elevation': None, 'transparent_blind': False, 'interp': False, 'interp_start': None, 'interp_end': None, 'interp_list': [], 'interp_list_new': [], 'lux_entity': None, 'lux_threshold': None, 'irradiance_entity': None, 'irradiance_threshold': None, 'outside_threshold': None, 'enable_max_position': False, 'enable_min_position': False})" } } }

basbruss commented 2 months ago

4. The manual override button remains in the off position.

Do you mean the switch? That has to be set to on before the integration can detect manual adjustments

lennon101 commented 5 days ago

@basbruss thanks for clarifying this. I came here because I was also confused about what that switch did. I didn't realise that the switch was essentially enabling the detection of manual operation. It makes sense but I feel like perhaps the documentation wasn't quite clear enough on this? I'd be happy to submit a pull request to make some minor tweaks to help clarify a bit more if that was okay with you?