base-org / contract-deployments

MIT License
184 stars 98 forks source link

Go Error when simulating with make sign-op #165

Open blmalone opened 3 months ago

blmalone commented 3 months ago

Steps to reproduce

git clone https://github.com/base-org/contract-deployments.git 
cd contract-deployments
cd mainnet/2024-04-17-upgrade-erc20-factory
make deps
make sign-op # simulate Optimism signers

While the tenderly link does get logged to the console, it doesn't finish execution gracefully.

e.g.

forge exited with code 0

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x18 pc=0x100c8069c]

goroutine 1 [running]:
main.main()
    /Users/blaine/go/pkg/mod/github.com/base-org/eip712sign@v0.0.6/main.go:113 +0x94c
make: *** [sign-op] Error 2

This may be something to do with my environment configuration.

go version
# go version go1.22.0 darwin/arm64

forge --version
# forge 0.2.0 (c486fca 2024-05-06T00:20:07.911403000Z)
ShubhSensei commented 1 month ago

May I work on this issue?

blmalone commented 1 month ago

@ShubhSensei go for it!

ShubhSensei commented 1 month ago