base-org / contract-deployments

MIT License
200 stars 108 forks source link

[mainnet] Set new L1 resolver as resolver for base.eth #201

Closed stevieraykatz closed 1 month ago

stevieraykatz commented 1 month ago

EXECUTED: https://etherscan.io/tx/0x15a5263c5531d27f6f91cfe79167ddaf0db38a29ce50106ff0e3380b468722df

The L1 Resolver contract set via 2024-07-23-set-l1-resolver runbook had a bug wherein generic resolve requests for the base.eth name itself were failing. This was due to the fact that the rootResolver does not implement the resolve method.

The issue with the contract was fixed in this PR and deployed in this SCM deploy. This runbook will set the resolver for the base.eth name to the newly deployed, fixed version of the L1 Resolver contract.

cb-heimdall commented 1 month ago

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1