search

base-org / pessimism

Detect real-time threats and events on OP Stack compatible blockchains
https://base-org.github.io/pessimism/
MIT License
1.54k stars 435 forks source link

Markdown linting support #159

Closed alessandromazza98 closed 1 year ago

alessandromazza98 commented 1 year ago

Closes #96

I add markdownlint support in CI with a config file .markdownlint.json in order to not display line length errors because I think they sometimes are necessary.

I add in the README.md the steps to lint md files so that there are no problems in CI.

Let me know what do you think. Thanks

adrain-cb commented 1 year ago

Hey @alessandromazza98, thanks for the contribution! Once the failing checks pass, I'll go ahead and give this a +1

alessandromazza98 commented 1 year ago

Now I get a golang-ci lint error but it's related to a file I did not change, which is health.go.

epociask commented 1 year ago

@alessandromazza98 I see that, for some reason the last merged PR introduced this regression which for some reason wasn't detected in CI. Nonetheless I've put another PR in the meantime to fix this. Once this is merged you should be able to rebase and we'll be smooth sailing ⛵

alessandromazza98 commented 1 year ago

Should be ok now