base-org / web

https://base.org
Apache License 2.0
252 stars 310 forks source link

Docs Request: TOML Parse Error in Tutorial for Using Pyth Price Feeds #313

Closed twynne20 closed 8 months ago

twynne20 commented 8 months ago

What is the issue you are encountering with the docs?

Problem: While following the tutorial on using Pyth Price Feeds on the Base testnet, I encountered a TOML parse error during the setup process described in the "Installing Pyth smart contracts" section. The error occurred when updating the foundry.toml file with the provided remappings line for Pyth SDK Solidity: remappings = ['@pythnetwork/pyth-sdk-solidity/=lib/pyth-sdk-solidity’]

The error message was:

Error: 
failed to extract foundry config:
foundry.toml error: TOML parse error at line 5, column 71
  |
5 | remappings = ['@pythnetwork/pyth-sdk-solidity/=lib/pyth-sdk-solidity’]
  |                                                                       ^
invalid literal string
 in foundry.toml TOML file

This appears to be caused by mismatched quotation marks in the remappings line provided in the tutorial.

Links to Impacted Docs

using-pyth-price-feeds.md

Describe the solution you'd like to see.

To prevent this error for others following the tutorial, the documentation should be updated to ensure that the quotation marks used in the foundry.toml code snippet are consistent. The corrected line should use matching single quotes (') or double quotes (") around the remapping path: remappings = ['@pythnetwork/pyth-sdk-solidity/=lib/pyth-sdk-solidity']

This minor correction will help future readers smoothly follow the tutorial without encountering parse errors in their foundry.toml configuration.

Additional context

No response

twynne20 commented 8 months ago

Closed: https://github.com/base-org/web/pull/314#issuecomment-1936104857