For contracts, all private and internal symbols should be prefixed with an _.
For libraries:
All private symbols should also be prefixed with an _.
All internal symbols should NOT be prefixed with an _. This is because we consider that the library internal symbols are part of its publicly exposed API. This seems to be a generally accepted convention, as library internals are often used instead of public ones to avoid performing an expensive additional DELEGATECALL.
This PR prefixes private constants with
_
.A few notes on the adopted style guide
We are most likely aligned with the Solidity style guide:
private
andinternal
symbols should be prefixed with an_
.private
symbols should also be prefixed with an_
.internal
symbols should NOT be prefixed with an_
. This is because we consider that the libraryinternal
symbols are part of its publicly exposed API. This seems to be a generally accepted convention, as libraryinternal
s are often used instead ofpublic
ones to avoid performing an expensive additionalDELEGATECALL
.