search

base-org / webauthn-sol

MIT License
203 stars 74 forks source link

🔧 chore: add remappings #14

Closed cruzdanilo closed 4 months ago

cruzdanilo commented 5 months ago

improves integration with solidity development tools.

example: fixes vscode solidity integration.

wilsoncusack commented 5 months ago

Appreciate! Can you say more if the issues you're facing. We like to avoid specifying remappings, re 2(c)(1) https://github.com/coinbase/solidity-style-guide

cruzdanilo commented 5 months ago

hey @wilsoncusack! when using webauthn-sol as a library, vscode solidity extension won't resolve the imports. here is a screenshot and a very simple repro: https://github.com/cruzdanilo/repro-webauthn

Screenshot 2024-04-04 at 18 15 13
wilsoncusack commented 5 months ago

I wonder if it depends on the solidity extension you use. These work for me.

cruzdanilo commented 5 months ago

i am using this one: https://github.com/juanfranblanco/vscode-solidity i think it's the most used one and should work out of the box. which one are you using?

wilsoncusack commented 5 months ago

https://marketplace.visualstudio.com/items?itemName=NomicFoundation.hardhat-solidity

wilsoncusack commented 4 months ago

Thanks for opening the issue, going to close for now!