search

base-org / webauthn-sol

MIT License
203 stars 74 forks source link

Fix for variable clientDataJSON serialization #6

Closed wilsoncusack closed 6 months ago

wilsoncusack commented 6 months ago

Our key assumption and optimization here turned out to be wrong: there are clients that have varied serialization of clientDataJSON.

E.g. in Mozilla the fields are ordered in the order they appear here.

With this change, our implementation basically mirrors Daimo and FreshCryptoLib, with the addition of the precompile call.

cb-heimdall commented 6 months ago

Review Error for stevieraykatz @ 2024-03-04 21:57:08 UTC User must have write permissions to review

cb-heimdall commented 6 months ago

Review Error for stevieraykatz @ 2024-03-04 23:12:46 UTC User must have write permissions to review