search

base / base-cwd

Base plugin that adds a getter/setter for the current working directory.
MIT License
12 stars 1 forks source link

Make special rules configurable #2

Open mootari opened 6 years ago

mootari commented 6 years ago

While scanning through the code I noticed a hardcoded rule for .DS_Store: https://github.com/node-base/base-cwd/blob/43a567e9725f070d13a813ebd3c5b7580d0cb807/index.js#L53-L55

This looks like something that was added under time pressure and should probably be made configurable. Even though I don't have a specific use case I wanted to mark it as a possible work item that can be adressed in the future.

jonschlinkert commented 6 years ago

I'm open to changing all of the logic in this lib. The main use case was to be able to detect when you are in an empty folder for scaffolding out a new project, et cetera, but .DS_Store causes a false negative. I'm not even sure if that belongs here.