destructive editing of termite config

[bssb]

When applying a theme, some of my termite config lines are being removed that are unrelated to the colorscheme.

$ diff config config.bac | head -n24
7c7,9
< 
---
> #fullscreen = true
> #icon_name = terminal
> cursor_blink = off
35,36c37,38
< # Base16 Outrun Dark
< # Author: Hugo Delahousse (http://github.com/hugodelahousse/)
---
> # Base16 Snazzy
> # Author: Chawye Hsu (https://github.com/h404bi) based on Hyper Snazzy Theme (https://github.com/sindresorhus/hyper-snazzy)
38,42c40,44
< foreground          = #D0D0FA
< foreground_bold     = #E0E0FF
< cursor              = #E0E0FF
< cursor_foreground   = #00002A
< background          = rgba(0, 0, 42)
---
> foreground          = #eff0eb
> foreground_bold     = #f1f1f0
> cursor              = #f1f1f0
> cursor_foreground   = #1e1f29
> background          = rgba(30, 31, 41, 0.9)

The 3 lines being removed are at the top of that diff. So it looks like cursor_blink is being mistaken for either cursor or cursor_foreground and removed along with the previous 2 commented lines.

[theova]

Thank you for the bug report.

So it looks like cursor_blink is being mistaken for either cursor or cursor_foreground and removed along with the previous 2 commented lines.

You're absolutely right, it is mistaken for cursor.

I've tried to solve this in #56 . It would be great, if you can test it (please carefully backup your configs before).

[bssb]

Thank you for addressing this so quickly! I have tested the change and can confirm #56 fixes the issue I was having. All of my config lines are left intact except the ones being replaced for the colorscheme. At the moment I am only using this to set colors for termite, rofi, and vim, but those all seem to be working without issue. I can't comment on if any other apps are affected.

[bssb]

There is one other thing, but perhaps I should open a separate issue for this as it seems more of a feature request than a bug. It would be nice to have termite retain the transparency level when the background color is changed. That is set in the 4th parameter below:

$ diff config config.bac | grep background
< background          = rgba(30, 31, 41)
> background          = rgba(30, 31, 41, 0.9)

Any thoughts on this?

[bssb]

I spoke too soon regarding rofi. I only have 4 lines in my config that are not related to colors, but they are all getting removed:

$ diff config config.bac
0a1,4
> rofi.kb-accept-entry: Control+m,Return,KP_Enter
> rofi.kb-remove-to-eol:
> rofi.kb-row-up: Control+k
> rofi.kb-row-down: Control+j

[kepi]

I spoke too soon regarding rofi. I only have 4 lines in my config that are not related to colors, but they are all getting removed:

I addressed problem with rofi config in #48 which was wating for work in #46. Now (minutes ago ;) ) both are ready and hopefully merged soon.

[hughwilliams94]

Any news on the transparency parameter, bit of a faff having to update it all the time