basecamp / kamal-proxy

Lightweight proxy server for Kamal
https://kamal-deploy.org/
MIT License
754 stars 31 forks source link

Adds middleware to insert X-Request-Start unix millis timestamp #70

Closed AxelTheGerman closed 4 days ago

AxelTheGerman commented 1 week ago

Implements #69

Note: I never wrote a line of Go before. I based everything on the X-Request-ID middleware implementation.

PS: make test passes for me locally

AxelTheGerman commented 1 week ago

@kevinmcconnell if you have a moment, I would appreciate your take on this feature/PR. Thank you so much for bringing all this to life, I was looking for something like Kamal for years :rocket:

kwilczynski commented 5 days ago

@AxelTheGerman, feel free to squash the commits into one.

AxelTheGerman commented 5 days ago

@AxelTheGerman, feel free to squash the commits into one.

Done!

Thanks again for the review and additional information on how everything works.

kwilczynski commented 5 days ago

@AxelTheGerman, feel free to squash the commits into one.

Done!

Thanks again for the review and additional information on how everything works.

@AxelTheGerman, my pleasure. Thank you for your contribution! Much appreciated. :tada:

We now need to wait for one of the maintainers to do a final round of reviews, etc.

kevinmcconnell commented 4 days ago

This is great, thanks @AxelTheGerman for the contribution, and @kwilczynski for the review. 🙏

Nice work! 👏