search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
10.6k stars 408 forks source link

Allow overriding custom `kamal` network #1006

Open luizkowalski opened 4 days ago

luizkowalski commented 4 days ago

hey 👋🏻

I'm running a couple of accessories that require host network mode and since v2, Kamnal forces the usage of custom kamal network.

Is there any chance to make this option configurable? These containers do not run behind a proxy anyway so there's no need for them to be discoverable

mblayman commented 4 days ago

According to the upgrade guide, the recommendation for customizing the network is to use the docker-setup hook. https://kamal-deploy.org/docs/upgrading/network-changes/

luizkowalski commented 4 days ago

then I would need to create a network called “kamal” with host access, which is far from ideal. i dont want all containers with host access, nor have to deal with port mapping because some containers port clash and host network exposes it all

igor-alexandrov commented 4 days ago

@djmb I can add a configuration option to change the network if you are okay with this.

djmb commented 4 days ago

then I would need to create a network called “kamal” with host access, which is far from ideal. i dont want all containers with host access, nor have to deal with port mapping because some containers port clash and host network exposes it all

I don't think this would work - it would put the app and proxy containers in a host network as well, and then the proxy won't be able to access the app container by its container ID.

@igor-alexandrov - yes please if you have a chance to add this 👍

We'd add something like network: <name> I guess and then you can set it to network: host?

accessories:
  redis:
    image: redis:latest
    port: 6379
    network: host