search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
11.01k stars 423 forks source link

Add delay before starting healtcheck #361

Closed Zeko369 closed 5 months ago

Zeko369 commented 1 year ago

In cases the app starts slower it might timeout while waiting for healthchecks to succeeded, our app for example starts up in 6th or 7th attempt (of the default 7) and while we can increase that to 8/9 it seams like a smarter thing would be to just "delay 10s" and then start the 1/2/3/4 sequence

This might make it faster since if the app starts in i.e. 20s and doesn't hit the 6th (21s) you need to wait for the next one which is 28s, while if we just add a 18s delay at the start it's gonna hit it faster (since the timeouts at the point will be 1/2/3s)

dorianmariecom commented 6 months ago

from @dhh on the pull request:

Not loving this. Having two independent dials to turn for this is imo too much.

So I think this should be closed no?