search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
10.66k stars 410 forks source link

Relax `dotenv` version #702

Closed adam12 closed 6 months ago

adam12 commented 7 months ago

Looking at the breaking changes listed for dotenv, it seems to only affect Rails applications that are directly using dotenv and are upgrading between versions of dotenv.

Presumably, if they were using dotenv directly, they would have the version of dotenv in their Gemfile that works for them, and we're safe to allow a newer version.

igor-alexandrov commented 6 months ago

@adam12 kamal is not required to be in the application Gemfile. There is no reason to relax its dependencies.

adam12 commented 6 months ago

DHH seems to suggest it should be used globally, so I'll close this.