search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
9.41k stars 362 forks source link

Pushing Build Should not Require Lock Acquire nor Server Setup #722

Closed rience closed 1 month ago

rience commented 4 months ago

When we deploy feature branches - we dynamically set up new servers based on branch name. However, when one only wants to run CI build and make sure test passes - we only build Docker image with kamal build push. At that point servers are not set up. Of course they can be - but that'd be waste of resources since not all feature branches are deployed.

I'm not sure if there's a reason why would kamal build push require servers to be set up. So this PR is removing call to mutating.

If this is a "no go" - would you consider PR where one could be passing "—skip-server-setup" or similar param?

djmb commented 1 month ago

Thanks @rience! I'm closing this as it was resolved by #755