search

basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
9.39k stars 359 forks source link

Add "tag_uncommitted" option to "builder" #776

Closed swombat closed 2 months ago

swombat commented 2 months ago

Discussed in issue https://github.com/basecamp/kamal/issues/775

This adds an option to builder so it doesn't mess up remote building when there are uncommitted local changes. Defaults to the same behaviour as now, so should not disrupt anyone's workflow, assuming there is anyone who actually wants that behaviour of making random build tags that can't be deployed later.

Apologies for the "Bump version" commits... this is my very first pull request..! I guess I shouldn't have run bin/release...

Usage is really simple:

builder:
  multiarch: false
  tag_uncommitted: false
  remote:
    arch: amd64
    host: ssh://[redacted]@[redacted]

With that line, now the random tag won't be added when there are uncommitted changes.

TODO: mention this in the docs?

morgoth commented 2 months ago

This can be closed as #775 is resolved