basecamp / kamal

Deploy web apps anywhere.
https://kamal-deploy.org
MIT License
9.71k stars 372 forks source link

dotenv version is too old #899

Open alec-c4 opened 1 month ago

alec-c4 commented 1 month ago

Hey! One more problem - dotenv version is too old.If you add kamal to your Gemfile you'll be unable to use newer version of dotenv gem in case of any. https://github.com/basecamp/kamal/blob/ec4aa4585278757302e592a2fc12fbf7e14f7b90/kamal.gemspec#L18C1-L18C41

Current version https://github.com/bkeepers/dotenv is 3.1.2

igor-alexandrov commented 1 month ago

Hi Alex, while we deal with dotenv version, you can use Kamal without adding it to the Gemfile.

To do this create a separate .kamal/Gemfile

source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby file: ".ruby-version"

gem "kamal", "~> 1.8"

After this install dependencies:

BUNDLE_GEMFILE=.kamal/Gemfile bundle install

And create binstub:

BUNDLE_GEMFILE=.kamal/Gemfile bundle binstub kamal --path ../bin
alec-c4 commented 1 month ago

@igor-alexandrov hey! It is a good idea, but looks like a workaround. From my point of view it is important to keep deps updated, am I wrong?

igor-alexandrov commented 1 month ago

Yes, deps should be kept up to date. I update dotenv. At the same time, my approach is not a workarond. Kamal depends from activesupport >= 7.0 and I use it to deploy Rails 6 and Rails 5 apps.

igor-alexandrov commented 1 month ago

@djmb this can be closed it seems.