basecamp / mail_view

Visual email testing
MIT License
1.33k stars 128 forks source link

Attachments inserted into preview of text emails #38

Closed bbuchalter closed 11 years ago

bbuchalter commented 11 years ago

This does not happen in the HTML version.

Screenshot from 2013-03-31 12:38:20

tylercollier commented 11 years ago

I'm seeing this too

tylercollier commented 11 years ago

@bbuchalter, actually, I'm seeing the exact same output in the html version. The only solution I have is to remove my text version during preview, and then it works fine. Have you tried it with an HTML part and TEXT part?

isaacsanders commented 11 years ago

We are seeing this as well.

jeremy commented 11 years ago

This happens when you have a multipart message, but not multipart/alternative, and the text/plain part doesn't come first. When no content type is specified, mailview uses the first mime part by default.

Fixing this to use either the first mime part of a multipart/alternative part or the first text part.

tylercollier commented 11 years ago

I updated to the latest version, 2.0.1, and it works as expected. I did not have to make any other changes, like the ordering of multipart parts. Awesome!