basecamp / omakub

Opinionated Ubuntu Setup
https://omakub.org
3.62k stars 274 forks source link

Highlighted Text not visible in Zellij #105

Open jkjarvis opened 3 weeks ago

jkjarvis commented 3 weeks ago

When working with Zellij and using highlight for copying or other purposes, the highlighted section isn't visible. I think since we are "darking" the highlighted portion with same theme color but a darker gradient, it isn't visible. Maybe need to use compliment colors if there is a config for this like white over grey etc.

jkjarvis commented 3 weeks ago

I think this is the solution ?

"Eduard You have to hold shift down to select for the system clipboard" ?

giyany commented 3 weeks ago

Copy+paste behavior can be different in different systems, but we've seen with Zellij + Alacritty the copy+paste is straightforward and reliable, usually not requiring Shift. We've also seen some themes in which the default highlight is too dark for the user to see. Omakub seems to come with several themes, so I'd start with changing the theme to see if that's the case.

manueldeprada commented 2 weeks ago

Yeah that works. I switched to gruvbox and selected text block is now visible in zellij

jkjarvis commented 2 weeks ago

It is still very dark for all themes. In vim mode, it is working fine but if in shell , you do cat then highlight the output, it is not visible.

ad798 commented 1 week ago

"Eduard You have to hold shift down to select for the system clipboard" ?

In my case, I can confirm that the highlight is too dark but is possible to copy the content from the terminal. Besides, holding shift down highlights the line with a visible color, as seen below:

image

ad798 commented 4 days ago

The new Omakub Manual states in the clipobard section:

Zellij requires that you hold down Shift when you select a line in the terminal that you wish to copy to the system clipboard.

So, I think is fine to close this issue.

florentdestremau commented 4 days ago

there are still issues on my side to select multines, because the borders of zellij are included

giyany commented 3 days ago

@florentdestremau This is a separate issue. In any case, borders can be disabled with ctrl+p z.

florentdestremau commented 3 days ago

thanks for the tip ! This should be a real issue in zellij.