search

basecamp / omakub

Opinionated Ubuntu Setup
https://omakub.org
4.85k stars 384 forks source link

Bash Script Not French-friendly #168

Closed Kobytes closed 3 months ago

Kobytes commented 3 months ago

There's an issue with the Bash script. Currently, the script doesn't work properly on Ubuntu systems configured in French. This is because the script specifically looks for folder names in English, such as "Downloads", "Documents", etc (as far as I can see).

However, on a French version of Ubuntu, these directories have different names, such as "Téléchargements", "Documents", etc. This prevents the script from running properly as it cannot find the expected directories.

I know that most developers (even French ones) have their OS in English, so I think it would be interesting to make it a little more "international" -- at least for those who have their OS in French and like the Omakub principle.

rmacklin commented 3 months ago

This is a duplicate of https://github.com/basecamp/omakub/issues/91 - the issue is already fixed on master in https://github.com/basecamp/omakub/commit/ec7655e75e6a8806c49b16c624c56ea75ff1eb51 but has not yet landed in the stable branch.