search

basecamp / omakub

Opinionated Ubuntu Setup
https://omakub.org
5.13k stars 414 forks source link

Consider adding Shellcheck to the project #45

Closed anavarre closed 4 months ago

anavarre commented 4 months ago

I reviewed the PRs and several comments were around code style. One way to solve this once and for all is to have an automated Github Action (as an example) that uses https://github.com/koalaman/shellcheck so all contributions respect the rules imposed by Shellcheck.

I also believe it'd be a great addition to omakub itself, but that's likely a different discussion altogether.

dhh commented 4 months ago

Would be happy to see it. Please open a PR to turn this on.