Stop loading .envrc - Githubissues

basecamp / pow

Zero-configuration Rack server for Mac OS X

http://pow.cx/

MIT License

3.4k stars 261 forks source link

Stop loading .envrc #462

Open diabolo opened 10 years ago

diabolo commented 10 years ago

Pow loads .envrc. If you are using this with direnv, this can cause pow to fail to load rack apps.

see /src/rack_application.coffee line 96

Direnv is often used with spring to configure the environment for rails. Pow does not document its loading of .envrc

It would be good if pow either

stopper using .envrc or
documented how to use .envrc safely (see https://github.com/basecamp/pow/issues/73)

ajb commented 10 years ago

:+1:

bclennox commented 9 years ago

It seems like this is only for backwards compatibility with very early versions of Pow (prior to 0.3.0 if #73 is right). Is that correct?

If so, is there a plan to deprecate support for .envrc? On the surface, it looks like a trivial change to the code (which I can open a PR for), but I'm sure I don't know all the implications.

ddgromit commented 9 years ago

flybayer commented 9 years ago

sentience commented 9 years ago

Crazyglue commented 8 years ago