basecamp / thruster

MIT License
672 stars 16 forks source link

Disable transparent proxy compression #11

Closed kevinmcconnell closed 3 months ago

kevinmcconnell commented 3 months ago

The default transport used by the proxy requests compressed responses even if the client didn't. If it receives a compressed response but the client wants uncompressed, the transport decompresses the response transparently.

Although that seems helpful, it doesn't play well with X-Sendfile responses, as it may result in us being handed a reference to a file on disk that is already compressed, and we'd have to similarly decompress it before serving it to the client. This is wasteful, especially since there was probably an uncompressed version of it on disk already. It's also a bit fiddly to do on the fly without the ability to seek around in the uncompressed content.

Compression between us and the upstream server is likely to be of limited use anyway, since we're only proxying from localhost. Given that fact -- and the fact that most clients will request compressed responses anyway, which makes all of this moot -- our best option is to disable this on-the-fly compression.

Fixes #6