basecamp / thruster

MIT License
672 stars 16 forks source link

Failure to launch wrapped process should be an error, not a panic #22

Closed kevinmcconnell closed 2 months ago

kevinmcconnell commented 2 months ago

As noted in #21, if we get an error when launching the wrapped process we currently panic. This makes the output look broken, and as a result it's harder to understand what went wrong. This is a valid error condition, so there's no need to crash here.

We should remove the panic, and change this so that failure to launch the process simply logs the error, and exits with a non-zero exit code. (Which is what it already does in the case that the process dies after launch).