search

basecamp / thruster

MIT License
912 stars 31 forks source link

Gzip does not work #6

Closed Novtopro closed 8 months ago

Novtopro commented 8 months ago

CleanShot 2024-03-09 at 21 07 58@2x

As you can see, the gzip does not work, not sure why. I use proshaft by the way.

kevinmcconnell commented 8 months ago

@Novtopro thanks for flagging this! It was indeed a bug. Compression was being applied to these responses even without the Accept-Encoding: gzip header present, which should not have been the case. You'd run into this bug if you have precompiled assets, and used a client that didn't request compressed responses (like curl does by default).

I've fixed this now, and will release a new version shortly that has the fix.

kevinmcconnell commented 8 months ago

Released gem version 0.1.3 which has this fix.