baseclass / Contrib.Nuget

Extending nuget with nuget packages
MIT License
30 stars 21 forks source link

Merge of Ouput and Output.web #14

Closed mnivet closed 9 years ago

mnivet commented 9 years ago

Happy to know that you've come back to perform an official support of this great package.

A brief description of all what we (me and others people of my company) do here in your absence:

When we tried to merge the existing pull request we observe that the pull request #7 has break the output.web package (because the UnzipNuspec task has been deleted)

So I start re-write and optimise multiple things around this issue because I also notice that multiple targets was computing again and again the same thing (Clean, CopyToOutput, and CollectNugetPackageFiles), which can be a performance issue. When running msbuild with the rebuild and publish targets the collection of nugets packages were evaluated 3 times.

In this final version Output.Web code as been merged in Output package, to avoid to modify one package and breaking the other, and to avoid to have to install another package when using a package depending on the first on in a WebSite project

And evaluation of the nuget packages depending on the Output package is now done only once through the CollectNugetOutputFiles target

Finally a fix in the unzip of nuget packages code has been perform to support concurrency (in our platform we do parallel builds with a common packages folder, and we occurred sometimes an error at that level)

There is some merge conflict, I look at them, and you can keep my version and override yours without any trouble. Pay attention that I re-number the versions 2.0 due to the big code changes, and the breaking status of the output.web packages that is now obsolete (the 2.0 version is empty, and should exists just for update purpose)