based-ghost / react-seo-friendly-spa-template

React PWA/SPA template initially scaffolded with CRA (Create React App) and configured for SEO. Makes use of prerendering and other techniques/packages in order to achieve a perfect "Lighthouse Score".
MIT License
52 stars 21 forks source link

Feature Request: Toggle Theme #3

Closed OGoodness closed 2 years ago

OGoodness commented 3 years ago

I really like your "Toggle Theme" on your website: https://www.basedghostdevelopment.com/

Was hoping you could implement that as a standard feature, or something. I'm having trouble replicating your results.

based-ghost commented 3 years ago

@OGoodness - Ya, I believe I can add that without too much work. The ThemeToggle component featured on that site is built using Vue's new composition API which very closely follows React Hooks API (so the translation into React code should be smooth).

OGoodness commented 3 years ago

That'd be great! I'll be sure to look out for an update on the Vue version :D

OGoodness commented 3 years ago

Have you gotten the chance to implement this?

based-ghost commented 3 years ago

@OGoodness - Sorry for the very late response. If you still need that "Toggle Theme" functionality, I have added that to the code base. You can check out the embedded demo gif in the README.md to get a an idea of how it looks in this application.

based-ghost commented 2 years ago

Added functionality.