search

basemkhirat / elasticsearch

The missing elasticsearch ORM for Laravel, Lumen and Native php applications
MIT License
401 stars 130 forks source link

Incompatible with laravel/scout ^5 #97

Closed jradtilbrook closed 5 years ago

jradtilbrook commented 5 years ago

This package does not work with laravel scout after version 4, where they changed the interface for the Laravel\Scout\Engines\Engine abstract class. I think the composer.json file should be updated to reflect this so it won't let you install it with incompatible peers.

You can see it was introduced in https://github.com/laravel/scout/commit/9f06b9c4d77879d53cf1680740b7f8bf19f78279

If you are willing, I would be able to provide a PR to add the conflict key to the composer to rectify this.

ClaudioVarandas commented 5 years ago

I have exactly the same issue:

Symfony\Component\Debug\Exception\FatalErrorException Declaration of Basemkhirat\Elasticsearch\ScoutEngine::map($results, $model) must be compatible with Laravel\Scout\Engines\Engine::map(Laravel\Scout\Builder $builder, $results, $model)

hernandezruizcesar commented 5 years ago

Just now, i have the same probem, can anybody help us?

jradtilbrook commented 5 years ago

Seems like this might be unmaintained. I'm going to close this issue to clear out my own backlog