Review and complete TODOs and FIXMEs before ship of diff

basepi / libgit2

The Library

http://libgit2.github.com

Other

0 stars 0 forks source link

Review and complete TODOs and FIXMEs before ship of diff #13

Open hausdorf opened 13 years ago

hausdorf commented 13 years ago

Often we'll write something like "FIXME/TODO: change this function name to something that makes more sense then int if_i_see_one_more_uncommented_function_in_libxdiff_i_am_sending_davide_libenzi_a_bomb_in_the_mail" in the code to remind ourselves that we have some shit to do.

We should:

Complete as many of these as possible
Before shipping
Unless we can't do it for some reason

basepi commented 13 years ago

Additionally, another common "I'll revisit this later" tag is FIXME, so we should definitely grep for those before shipping as well, and resolve as many as possible.

hausdorf commented 13 years ago

I use FIXME extensively but didn't mention it.

basepi commented 13 years ago

Just wanted to make the issue's info as complete as possible. =)

trane commented 13 years ago

How much of this is fixed in @DrSleep private branch? I can go through whatever you haven't cleaned up if you merge it. https://github.com/crakdmirror/libgit2/issues/38

hausdorf commented 13 years ago

Not much. But don't fix it up quite yet.