basepi / libgit2

The Library
http://libgit2.github.com
Other
0 stars 0 forks source link

Use OS-agnostic IO handlers #14

Closed hausdorf closed 13 years ago

hausdorf commented 13 years ago

PROBLEM:

Current implementation of src/diff.c uses a method called load_file(). This opens a file given a directory. Arguably, though, this is a function that belongs in a file whose job it is to supply OS-agnostic IO handlers. As it turns out, this instinct is correct, as there is such a file, which you will see in the "resources" section.

OBJECTIVES:

RESOURCES:

basepi commented 13 years ago

Thanks for finding those fileops files, they were incredibly useful and, as far as I could see, feature-complete.

As far as I can tell, this issue is fixed. I have removed the load_files() method and the file_exists() method, refactoring all their uses with the equivalent methods from fileops.[h,c]. Closing it for now, if I've missed something, someone please re-open it, eh?

hausdorf commented 13 years ago

Glad to hear it.