search

basepi / libgit2

The Library
http://libgit2.github.com
Other
0 stars 0 forks source link

Use or define the libdiff malloc #23

Closed hausdorf closed 13 years ago

hausdorf commented 13 years ago

We're currently just calling free() and malloc(). This isn't extensible. We should define some sort of macro that specifies which malloc we're using, and it should probably default to libgit's malloc. I propose we call it ld_malloc()

trane commented 13 years ago

I have been coding against... ld_malloc() and ld_free() for patience.

hausdorf commented 13 years ago

I have misinformed you. libgit uses this style: git__malloc(), with two underscores. Correspondingly, I've just incorporated a libdiff malloc under the name ld__malloc in libdiff.h. You can see this implementation here.

Apologies for the confusion.

trane commented 13 years ago

cool.

hausdorf commented 13 years ago

Shouldn't have been closed; we need to actually implement it now.

hausdorf commented 13 years ago

This is now implemented for libdiff.

@kyeana, @crakdmirror, what malloc are you using? Can I close this?

vimalloc commented 13 years ago

Git__malloc On Apr 22, 2011 10:08 PM, "DrSleep" < reply@reply.github.com> wrote:

This should actually be implemented.

@kyeana, @crakdmirror, what malloc are you using?

Reply to this email directly or view it on GitHub: https://github.com/crakdmirror/libgit2/issues/23#comment_1046573

hausdorf commented 13 years ago

Awesome. Then I'm closing this issue.