search

basepi / libgit2

The Library
http://libgit2.github.com
Other
0 stars 0 forks source link

Function Declarations #26

Closed vimalloc closed 7 years ago

vimalloc commented 13 years ago

We are declaring some function at the top of .c files like such: https://github.com/crakdmirror/libgit2/blob/development/src/diff.c#L13

I understand why we would do this, but glancing around it doesn't look like the rest of the project is doing this. Is it ok if we remove these to keep the same feel as the rest of the project?

hausdorf commented 13 years ago

Probably right. I'm going to worry less about style issues right now, but in the future it will be important.

basepi commented 13 years ago

Sounds fine to me. Theoretically, load_file, which was on the line you referenced, won't be even necessary, and ya, I figure we should follow the style of the project.

On Thu, Apr 21, 2011 at 8:01 PM, kyeana < reply@reply.github.com>wrote:

We are declaring some function at the top of .c files like such: https://github.com/crakdmirror/libgit2/blob/development/src/diff.c#L13

I understand why we would do this, but glancing around it doesn't look like the rest of the project is doing this. Is it ok if we remove these to keep the same feel as the rest of the project?

Reply to this email directly or view it on GitHub: https://github.com/crakdmirror/libgit2/issues/26