basf / MolPipeline

MIT License
89 stars 4 forks source link

The option 'deep' in the method get_params triggers a different behaviour than sklearns implementation. #28

Open c-w-feldmann opened 2 months ago

c-w-feldmann commented 2 months ago

In our implementation, deep=True will return the parameter as copy by value, whereas in sklearn this option will return the parameters of the object and the parameters of contained objects (Where the parameter name has the prefix object_name__).
I think we should adapt our behavior accordingly.