Fix parsing for redirection

basgren / railways

A plugin for RubyMine and IntelliJ IDEA Ultimate that adds a panel with routes of Ruby on Rails application.

MIT License

46 stars 18 forks source link

Closed kotaro0522 closed 3 years ago

kotaro0522 commented 4 years ago

Hi. I have fixed parsing for redirection because of the following reason.

a matches method doesn't return true when a redirecting action of routes contains additional requirements https://stackoverflow.com/questions/20165485/why-is-string-matches-returning-false-in-java
- example: redirect(301, https://google.com) {:subdomain=>"foo"}
a URI can contain # as a URI fragment https://en.wikipedia.org/wiki/URI_fragment

I'd be glad if you include this into the next release. Thanks!

basgren commented 3 years ago

Thank you very much for the PR! I've also added tests for your case. Will be released soon.