bash
commented
4 months ago Agreed. Empty lines should be considered leading/trailing trivia instead of unrecognized nodes. [^1]
I don't plan on working on this soon, but I'm open to PRs :)
A couple of pointers towards a PR:
- Currently the
LeadingTriviaandTrailingTriviaproperties are on individual nodes. I think it would make sense to move that to the abstractSectionChildIniNodeor evenIniNode. - Currently the
LeadingTriviaandTrailingTriviaproperties are a singleWhiteSpacetoken. I would change that to anIImmutableList<IniToken>.- Don't forget to update the
GetHashCodeandEqualsimpls.
- Don't forget to update the
IniNode.NewLineshould still hold the last newline before the next node.- Changing empty lines to be leading trivia only makes sense for the first section node and the first child node of each section. Otherwise trivia is usually trailing for the preceding node.
- Garbage lines (a line that has neither a
=or[) should still result inUnrecognizedIniNodes. UnrecognizedIniNodehas an internalIsBlank()method. That probably isn't needed anymore after your change.
[^1]: The third blank line in your example is not ignored. The final newline is included in the NewLine property of your key-value node (I made the line endings explicit using ␊):
```
␊
[section]␊
␊
key=value␊
```
If there were two line feeds at the end of the document I would agree with you :)
csillikd
Here
the first two empty lines are recognized as
UnrecognizedIniNodes, and the third one is ignored.I think the first belongs to the section node as leading trivia, the second as trailing trivia, and the third empty line belongs to the
KeyValueIniNodeas trailing trivia.It would also help to decide whether the document is well-formatted.