search

bash / terminal-colorsaurus

A library for answering the question «Is this terminal dark or light?» 🦕
Apache License 2.0
19 stars 3 forks source link

ColorScheme is a misnomer #18

Open teohhanhui opened 4 months ago

teohhanhui commented 4 months ago

First off, great library! This was hilarious and well deserved: https://docs.rs/terminal-colorsaurus/latest/terminal_colorsaurus/#comparison-with-other-crates

Dark / light refers to the "theme", not the "color scheme" (which is a separate thing).

bash commented 4 months ago

Thanks 😊

I think I picked the name with the perfers-color-scheme media query in CSS in mind But I'm not that set on the name as most other places I've come across refer to dark/light as a "theme" choice.

I'll leave this issue open and think about the naming in case I make other breaking changes to the library.

teohhanhui commented 4 months ago

I think I picked the name with the prefers-color-scheme media query in CSS in mind

That's fair. Unfortunately color scheme already means something else when it comes to terminals... :laughing:

bash commented 2 months ago

I'm not particularly fond of "theme"–I've also seen it be used to mean "color palette". For example this page uses "theme" and "color scheme" interchangeably :/

Wezterm uses the term "appearance" to refer to the dark/light/high contrast state of the window environment, which I quite like.

teohhanhui commented 2 months ago

LightDarkMode would be unambiguous, even if not exactly pleasant. But yeah, that wouldn't really work if there are more variants lol

GNOME calls it "style" under "appearance". But I think all of these terms are too unspecific / ambiguous...

bash commented 2 months ago

I have thought going in the direction of LightDarkMode, but that's so ... verbose 👀