search

bash0 / cewe2pdf

A python script to turn cewe photobooks into pdfs
GNU General Public License v3.0
43 stars 26 forks source link

Linux, mcfx and font improvements #135

Closed cweiske closed 6 months ago

cweiske commented 6 months ago

Assorted collection of patches I deem helpful.

Notable commits:

Feel free to only cherry pick the ones you like.

AnEnglishmanInNorway commented 6 months ago

Cherry picked the whole bunch to my fork, looked ok to me so I've merged it to bash0/cewe2pdf. Might as well have the best version available in the most obvious place :-). I'm vaguely interested to know how you identified the somewhat exotic list of fonts that were affected by having Regular in their normal name? By hand, or do you actually have a test that uses all the fonts?

On Sun, 5 May 2024 at 15:12, Christian Weiske @.***> wrote:

Assorted collection of patches I deem helpful. The last one resolves #134 https://github.com/bash0/cewe2pdf/issues/134.

Feel free to only cherry pick the ones you like.

You can view, comment on, or merge this pull request online at:

https://github.com/bash0/cewe2pdf/pull/135 Commit Summary

File Changes

(3 files https://github.com/bash0/cewe2pdf/pull/135/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/bash0/cewe2pdf/pull/135, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBIDKMBS3GSYD6CIYBG5B3ZAYV5BAVCNFSM6AAAAABHHW74LCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TSNJSGY3DQMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cweiske commented 6 months ago

I'm vaguely interested to know how you identified the somewhat exotic list of fonts that were affected by having Regular in their normal name

During development of the patch I simply print()ed the names affected by my if statement.

AnEnglishmanInNorway commented 6 months ago

Of course. Getting the fonts "right" is not exactly straightforward so I think it would be useful to notify the special cases we have found and handled as we go past them! Perhaps we should leave the output in place as an info level log entry.

On Sun, 5 May 2024 at 21:26, Christian Weiske @.***> wrote:

I'm vaguely interested to know how you identified the somewhat exotic list of fonts that were affected by having Regular in their normal name

During development of the patch I simply print()ed the names affected by my if statement.

— Reply to this email directly, view it on GitHub https://github.com/bash0/cewe2pdf/pull/135#issuecomment-2094920617, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBIDKOXGQYFGHQTRDETSTDZA2BUHAVCNFSM6AAAAABHHW74LCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHEZDANRRG4 . You are receiving this because you modified the open/close state.Message ID: @.***>